Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1576 again #1617

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

davidnixon
Copy link
Collaborator

@davidnixon davidnixon commented Jul 25, 2024

Contributes to #1576

What did you do?

moved postinstall to its own js script

Why did you do it?

fix npm 10+

How have you tested it?

This time test both installing via a tgz file AND installing from a local registry.
Test steps:

  • Confirm that installing 3.0.18 fails with npm 10 when installing (see reproduction steps in Cannot install carbon-vue on fresh Vue 3 project #1576)
  • Confirmed that the same 3.0.18 also fails when installing with npm 10 from a local npm registry (see compose in local-dev and the updated README for how to test this.)
  • Changed postinstall to a script that detects prod/dev install.
  • Built new version and posted this version to local npm registry
  • Confirmed that the new 3.0.18+ installs properly with npm 10 from a local npm registry
  • Confirmed that the dev install (yarn install) still installs the husky hooks & storybook custom controls

Were docs updated if needed?

  • Yes

Copy link

@guilherme-gm guilherme-gm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my machine with the local registry like you added in the README. Works for me too!

@davidnixon davidnixon merged commit a80a3a1 into carbon-design-system:main Jul 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants